Skip to content

Commit

Permalink
[#6481] improve(CLI): Refactor table output format
Browse files Browse the repository at this point in the history
Rename the constant.
  • Loading branch information
Abyss-lord committed Feb 19, 2025
1 parent 28e3c13 commit 9f9cbd8
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import com.google.common.collect.ImmutableList;

public class Constant {
public class OutputConstant {
public static final ImmutableList<Character> BASIC_ASCII =
ImmutableList.of(
'+', '-', '+', '+', '|', '|', '|', '+', '-', '+', '+', '|', '|', '|', '+', '-', '+', '+',
Expand Down Expand Up @@ -56,7 +56,7 @@ public class Constant {
public static final int HEADER_BOTTOM_BORDER_COLUMN_SEPARATOR_IDX = 20;
public static final int HEADER_BOTTOM_BORDER_RIGHT_IDX = 21;

private Constant() {
private OutputConstant() {
// private constructor to prevent instantiation
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,25 @@
*/
package org.apache.gravitino.cli.outputs;

import static org.apache.gravitino.cli.outputs.Constant.DATA_LINE_COLUMN_SEPARATOR_IDX;
import static org.apache.gravitino.cli.outputs.Constant.DATA_LINE_LEFT_IDX;
import static org.apache.gravitino.cli.outputs.Constant.DATA_LINE_RIGHT_IDX;
import static org.apache.gravitino.cli.outputs.Constant.DATA_ROW_BORDER_COLUMN_SEPARATOR_IDX;
import static org.apache.gravitino.cli.outputs.Constant.DATA_ROW_BORDER_LEFT_IDX;
import static org.apache.gravitino.cli.outputs.Constant.DATA_ROW_BORDER_MIDDLE_IDX;
import static org.apache.gravitino.cli.outputs.Constant.DATA_ROW_BORDER_RIGHT_IDX;
import static org.apache.gravitino.cli.outputs.Constant.HEADER_BOTTOM_BORDER_COLUMN_SEPARATOR_IDX;
import static org.apache.gravitino.cli.outputs.Constant.HEADER_BOTTOM_BORDER_LEFT_IDX;
import static org.apache.gravitino.cli.outputs.Constant.HEADER_BOTTOM_BORDER_MIDDLE_IDX;
import static org.apache.gravitino.cli.outputs.Constant.HEADER_BOTTOM_BORDER_RIGHT_IDX;
import static org.apache.gravitino.cli.outputs.Constant.TABLE_BOTTOM_BORDER_COLUMN_SEPARATOR_IDX;
import static org.apache.gravitino.cli.outputs.Constant.TABLE_BOTTOM_BORDER_LEFT_IDX;
import static org.apache.gravitino.cli.outputs.Constant.TABLE_BOTTOM_BORDER_MIDDLE_IDX;
import static org.apache.gravitino.cli.outputs.Constant.TABLE_BOTTOM_BORDER_RIGHT_IDX;
import static org.apache.gravitino.cli.outputs.Constant.TABLE_UPPER_BORDER_COLUMN_SEPARATOR_IDX;
import static org.apache.gravitino.cli.outputs.Constant.TABLE_UPPER_BORDER_LEFT_IDX;
import static org.apache.gravitino.cli.outputs.Constant.TABLE_UPPER_BORDER_MIDDLE_IDX;
import static org.apache.gravitino.cli.outputs.Constant.TABLE_UPPER_BORDER_RIGHT_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.DATA_LINE_COLUMN_SEPARATOR_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.DATA_LINE_LEFT_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.DATA_LINE_RIGHT_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.DATA_ROW_BORDER_COLUMN_SEPARATOR_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.DATA_ROW_BORDER_LEFT_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.DATA_ROW_BORDER_MIDDLE_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.DATA_ROW_BORDER_RIGHT_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.HEADER_BOTTOM_BORDER_COLUMN_SEPARATOR_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.HEADER_BOTTOM_BORDER_LEFT_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.HEADER_BOTTOM_BORDER_MIDDLE_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.HEADER_BOTTOM_BORDER_RIGHT_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.TABLE_BOTTOM_BORDER_COLUMN_SEPARATOR_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.TABLE_BOTTOM_BORDER_LEFT_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.TABLE_BOTTOM_BORDER_MIDDLE_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.TABLE_BOTTOM_BORDER_RIGHT_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.TABLE_UPPER_BORDER_COLUMN_SEPARATOR_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.TABLE_UPPER_BORDER_LEFT_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.TABLE_UPPER_BORDER_MIDDLE_IDX;
import static org.apache.gravitino.cli.outputs.OutputConstant.TABLE_UPPER_BORDER_RIGHT_IDX;

import com.google.common.base.Preconditions;
import java.io.ByteArrayOutputStream;
Expand Down Expand Up @@ -107,7 +107,7 @@ public String getTableFormat(Column... columns) {
.filter(Objects::nonNull)
.toArray(String[]::new);

List<Character> borders = Constant.BASIC_ASCII;
List<Character> borders = OutputConstant.BASIC_ASCII;
checkHeaders(headers, columns);

if (headers.length != columns.length) {
Expand Down

0 comments on commit 9f9cbd8

Please sign in to comment.