Add check to prevent redundant values in headers when using GZIPOutInterceptor #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
reviewed
Apr 19, 2024
core/src/main/java/org/apache/cxf/transport/common/gzip/GZIPOutInterceptor.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Apr 20, 2024
core/src/main/java/org/apache/cxf/transport/common/gzip/GZIPOutInterceptor.java
Show resolved
Hide resolved
reta
approved these changes
Apr 20, 2024
|
Thanks @yvrng ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use a custom feature to retry a client request if it fails. Unfortunately, on each attempt, the
Content-Encodingheader is modified to addgzip, givingContent-Encoding: gzip,gzipon the 2nd attempt.I've added a small check before adding the value to the header, to make sure it's not already defined with the expected value.