Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cxf.zipkin-reporter.version from 2.17.2 to 3.0.2 #1629

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 9, 2024

Bumps cxf.zipkin-reporter.version from 2.17.2 to 3.0.2.
Updates io.zipkin.reporter2:zipkin-reporter-brave from 2.17.2 to 3.0.2

Release notes

Sourced from io.zipkin.reporter2:zipkin-reporter-brave's releases.

Zipkin Reporter 3.0.1 fixes a problem where classpath scanners such as spring would trigger a zipkin2.Span class load on AsyncZipkinSpanHandler in zipkin-reporter-brave, which intentionally has no dependency on that.

Zipkin Reporter 3.0.0 makes the io.zipkin.zipkin2:zipkin dependency of io.zipkin.reporter2:zipkin-reporter-brave optional. This means those using the AsyncZipkinSpanHandler will have no dependencies except any sender they configure. In particular, this allows those using Brave for things besides zipkin (e.g. wavefront) to avoid a dependency. Also, those sending spans zipkin have simpler dependency configuration and save a couple hundred KB, as well.

Those using types from the core io.zipkin.reporter2:zipkin-reporter artifact should depend on this directly, possibly using our bom to align deps. io.zipkin.reporter2:zipkin-reporter still defaults to depend on io.zipkin.zipkin2:zipkin, but it can be excluded if you know what you are doing.

Technically, some base classes to accommodate this, but they don't have affect on call sites except those implementing a custom Reporter or Sender. Due to these type changes, this is a major version change. However, must users will have a drop-in experience, except possibly dependency configuration changes.

Thanks a lot to @​anuraaga and @​reta who helped think through this!

Commits
  • 4587e0e [maven-release-plugin] prepare release 3.0.2
  • 3f9229d [maven-release-plugin] prepare for next development iteration
  • a21e3e4 [maven-release-plugin] prepare release 3.0.1
  • 20e9f6d Clarifies README about explicit dep when adapting to brave (#237)
  • 3e6f163 Decouples AsyncZipkinSpanHandler from ZipkinSpanHandler to avoid leak (#238)
  • af0f4d5 [maven-release-plugin] prepare for next development iteration
  • 0bca54d [maven-release-plugin] prepare release 3.0.0
  • c05b82c Decouples from io.zipkin.zipkin2:zipkin (#234)
  • ca6aa21 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Updates io.zipkin.reporter2:zipkin-sender-urlconnection from 2.17.2 to 3.0.2

Release notes

Sourced from io.zipkin.reporter2:zipkin-sender-urlconnection's releases.

Zipkin Reporter 3.0.1 fixes a problem where classpath scanners such as spring would trigger a zipkin2.Span class load on AsyncZipkinSpanHandler in zipkin-reporter-brave, which intentionally has no dependency on that.

Zipkin Reporter 3.0.0 makes the io.zipkin.zipkin2:zipkin dependency of io.zipkin.reporter2:zipkin-reporter-brave optional. This means those using the AsyncZipkinSpanHandler will have no dependencies except any sender they configure. In particular, this allows those using Brave for things besides zipkin (e.g. wavefront) to avoid a dependency. Also, those sending spans zipkin have simpler dependency configuration and save a couple hundred KB, as well.

Those using types from the core io.zipkin.reporter2:zipkin-reporter artifact should depend on this directly, possibly using our bom to align deps. io.zipkin.reporter2:zipkin-reporter still defaults to depend on io.zipkin.zipkin2:zipkin, but it can be excluded if you know what you are doing.

Technically, some base classes to accommodate this, but they don't have affect on call sites except those implementing a custom Reporter or Sender. Due to these type changes, this is a major version change. However, must users will have a drop-in experience, except possibly dependency configuration changes.

Thanks a lot to @​anuraaga and @​reta who helped think through this!

Commits
  • 4587e0e [maven-release-plugin] prepare release 3.0.2
  • 3f9229d [maven-release-plugin] prepare for next development iteration
  • a21e3e4 [maven-release-plugin] prepare release 3.0.1
  • 20e9f6d Clarifies README about explicit dep when adapting to brave (#237)
  • 3e6f163 Decouples AsyncZipkinSpanHandler from ZipkinSpanHandler to avoid leak (#238)
  • af0f4d5 [maven-release-plugin] prepare for next development iteration
  • 0bca54d [maven-release-plugin] prepare release 3.0.0
  • c05b82c Decouples from io.zipkin.zipkin2:zipkin (#234)
  • ca6aa21 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `cxf.zipkin-reporter.version` from 2.17.2 to 3.0.2.

Updates `io.zipkin.reporter2:zipkin-reporter-brave` from 2.17.2 to 3.0.2
- [Release notes](https://github.com/openzipkin/zipkin-reporter-java/releases)
- [Changelog](https://github.com/openzipkin/zipkin-reporter-java/blob/master/RELEASE.md)
- [Commits](openzipkin/zipkin-reporter-java@2.17.2...3.0.2)

Updates `io.zipkin.reporter2:zipkin-sender-urlconnection` from 2.17.2 to 3.0.2
- [Release notes](https://github.com/openzipkin/zipkin-reporter-java/releases)
- [Changelog](https://github.com/openzipkin/zipkin-reporter-java/blob/master/RELEASE.md)
- [Commits](openzipkin/zipkin-reporter-java@2.17.2...3.0.2)

---
updated-dependencies:
- dependency-name: io.zipkin.reporter2:zipkin-reporter-brave
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: io.zipkin.reporter2:zipkin-sender-urlconnection
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 9, 2024
@reta
Copy link
Member

reta commented Jan 10, 2024

Closing, will be addressed by https://issues.apache.org/jira/browse/CXF-8969

@reta reta closed this Jan 10, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 10, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/cxf.zipkin-reporter.version-3.0.2 branch January 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant