Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] Make update-checksums.R work on macOS out of the box #45617

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Feb 24, 2025

Rationale for this change

For R release managers on macOS, the update-checksums.R script we use doesn't run because the sed command we use in that script only works on GNU sed and not BSD sed.

What changes are included in this PR?

  • Makes update-checksum-R work on macOS by assuming the user has gsed available from Homebrew and using that always

Are these changes tested?

Yes

Are there any user-facing changes?

No.

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice thanks! does mac sed not support -i?

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Feb 24, 2025
@amoeba
Copy link
Member Author

amoeba commented Feb 24, 2025

macOS has BSD sed which just does -i differently than GNU sed.

@amoeba amoeba merged commit bcda71d into apache:main Feb 24, 2025
11 checks passed
@amoeba amoeba removed the awaiting committer review Awaiting committer review label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants