-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45605: [R][C++] Fix identifier ... preceded by whitespace warnings #45606
base: main
Are you sure you want to change the base?
Conversation
@github-actions crossbow submit test-r-linux-as-cran |
Revision: c81bfb0 Submitted crossbow builds: ursacomputing/crossbow @ actions-4e0e69ed96
|
@github-actions crossbow submit test-r-linux-as-cran |
Revision: 27b318c Submitted crossbow builds: ursacomputing/crossbow @ actions-72b7eea56e
|
The clang20 job is failing due to not having latex (cf r-hub/containers#23) which we can ignore in this case, but won't be able to add it to the matrix if we need to ignore it — that's ok though, we just need to check this. It doesn't reproduce the failure we saw on CRAN but the clang20 image is out of date from r-hub. I pushed r-hub/containers#89 upstream to update the clang20 build, and then once that's failing can see if we get that same error. |
@github-actions crossbow submit test-r-linux-as-cran |
|
@github-actions crossbow submit test-r-linux-as-cran |
|
@github-actions crossbow submit test-r-linux-as-cran |
Revision: 1f5438d Submitted crossbow builds: ursacomputing/crossbow @ actions-c4c3a36e7c
|
@@ -21,20 +21,21 @@ | |||
|
|||
jobs: | |||
as-cran: | |||
name: "rhub/{{ MATRIX }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this?
Lines 1157 to 1158 in 12cdaaa
params: | |
MATRIX: {{ "${{ matrix.r_image }}" }} |
Rationale for this change
Fix warnings, pass on CRAN
What changes are included in this PR?
Removing some whitespace
Are these changes tested?
YEs
Are there any user-facing changes?
No, other than being releasable on CRAN