Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45605: [R][C++] Fix identifier ... preceded by whitespace warnings #45606

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jonkeane
Copy link
Member

@jonkeane jonkeane commented Feb 23, 2025

Rationale for this change

Fix warnings, pass on CRAN

What changes are included in this PR?

Removing some whitespace

Are these changes tested?

YEs

Are there any user-facing changes?

No, other than being releasable on CRAN

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Feb 23, 2025
Copy link

Revision: c81bfb0

Submitted crossbow builds: ursacomputing/crossbow @ actions-4e0e69ed96

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 27b318c

Submitted crossbow builds: ursacomputing/crossbow @ actions-72b7eea56e

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

jonkeane commented Feb 23, 2025

The clang20 job is failing due to not having latex (cf r-hub/containers#23) which we can ignore in this case, but won't be able to add it to the matrix if we need to ignore it — that's ok though, we just need to check this. It doesn't reproduce the failure we saw on CRAN but the clang20 image is out of date from r-hub. I pushed r-hub/containers#89 upstream to update the clang20 build, and then once that's failing can see if we get that same error.

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Failed to render template `r/github.linux.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/13486720494

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Failed to render template `r/github.linux.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/13486744445

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 1f5438d

Submitted crossbow builds: ursacomputing/crossbow @ actions-c4c3a36e7c

Task Status
test-r-linux-as-cran GitHub Actions

@@ -21,20 +21,21 @@

jobs:
as-cran:
name: "rhub/{{ MATRIX }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this?

arrow/dev/tasks/tasks.yml

Lines 1157 to 1158 in 12cdaaa

params:
MATRIX: {{ "${{ matrix.r_image }}" }}

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes Awaiting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants