Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45485: [Dev] Simplify pull request template #45599

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

kou
Copy link
Member

@kou kou commented Feb 21, 2025

Rationale for this change

It seems that the current comment based pull request template isn't read carefully.

What changes are included in this PR?

  • Remove explanations as comments
  • Keep a basic introduction in the top as a normal text not a comment
  • Use normal texts not comments for breaking changes and critical fix

Are these changes tested?

No.

Are there any user-facing changes?

No. This is only for developers.

Copy link

⚠️ GitHub issue #45485 has been automatically assigned in GitHub to PR creator.

Copy link

@singh1203 singh1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@raulcd raulcd merged commit 12cdaaa into apache:main Feb 21, 2025
7 checks passed
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Feb 21, 2025
@kou kou deleted the dev-pr-template branch February 21, 2025 09:22
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 12cdaaa.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants