GH-45582: [Python] Preserve decimal32/64/256 metadata in Schema.metadata #45583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Before, these types would be interpreted as
"object"type and therefore theprecisionandscaleattributes of these types would not be preserved in the"metadata"What changes are included in this PR?
Uses
pa.types.is_decimalis instead ofisinstanceing just theDecimal128Typeto determine a"decimal"pandas typeAre these changes tested?
Yes
Are there any user-facing changes?
Yes
closes #45582
pyarrow.pandas_compat.get_logical_type(pyarrow.decimal32/64(...))returns object instead of decimal #45582