-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41816: [C++] Add Minimal Meson Build of libarrow #45441
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b03b6aa
GH-41816: [C++] Meson Build System Support
WillAyd f18d495
Build minimal library without options
WillAyd 400155f
Complete configuration file
WillAyd 79fe13e
Install headers and add pkgconfig support
WillAyd d0ffa01
kou feedback
WillAyd 90c1249
Accumulate sources, dependencies, and includes
WillAyd a4514b4
Remove undefined symbol allowance
WillAyd dde9241
Add support for updating version in release process
kou 564df5f
Add a nightly CI job
kou 428c2f3
Remove comment and sort header installs
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,7 @@ libprotobuf | |
libutf8proc | ||
lz4-c | ||
make | ||
meson | ||
ninja | ||
nodejs | ||
orc | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
project( | ||
'arrow', | ||
'cpp', | ||
'c', | ||
version: '20.0.0-SNAPSHOT', | ||
license: 'Apache-2.0', | ||
meson_version: '>=1.3.0', | ||
default_options: [ | ||
'buildtype=release', | ||
'c_std=c99', | ||
'warning_level=2', | ||
'cpp_std=c++17', | ||
], | ||
) | ||
|
||
project_args = [ | ||
'-Wno-unused-parameter', | ||
'-Wno-array-bounds', | ||
'-Wno-stringop-overflow', | ||
'-Wno-aggressive-loop-optimizations', | ||
'-Wno-nonnull', | ||
] | ||
|
||
c_compiler = meson.get_compiler('c') | ||
c_args = c_compiler.get_supported_arguments(project_args) | ||
add_project_arguments(c_args, language: 'c') | ||
|
||
cpp_compiler = meson.get_compiler('cpp') | ||
cpp_args = cpp_compiler.get_supported_arguments(project_args) | ||
add_project_arguments(cpp_args, language: 'cpp') | ||
|
||
git_id = get_option('git_id') | ||
if git_id == '' | ||
git_id = run_command('git', 'log', '-n1', '--format=%H', check: false).stdout().strip() | ||
endif | ||
|
||
git_description = get_option('git_description') | ||
if git_description == '' | ||
git_description = run_command('git', 'describe', '--tags', check: false).stdout().strip() | ||
endif | ||
|
||
subdir('src/arrow') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
option( | ||
'git_id', | ||
type: 'string', | ||
) | ||
|
||
option( | ||
'git_description', | ||
type: 'string', | ||
) | ||
|
||
option( | ||
'package_kind', | ||
type: 'string', | ||
description: 'Arbitrary string that identifies the kind of package (for informational purposes)', | ||
) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We aren't building any tests now, are we? On the current CI:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now we aren't actually building any tests - just creating an MRE for Meson with libarrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. We'll add tests later.