Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44911: [C#] Choose port numbers dynamically for ArrowStreamWriterTests #44912

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented Dec 3, 2024

What changes are included in this PR?

ArrowStreamWriterTests.CanWriteToNetworkStream and ArrowStreamWriterTests.CanWriteToNetworkStreamAsync pick ports dynamically instead of hardcoding a static port.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Resolves #44911.

@CurtHagenlocher CurtHagenlocher merged commit c7e3122 into apache:main Dec 3, 2024
9 checks passed
@CurtHagenlocher CurtHagenlocher removed the awaiting review Awaiting review label Dec 3, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c7e3122.

There were 132 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] ArrowStreamWriterTests are failing
1 participant