Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38936: [JS] Add bundle test for toNodeStream failures #39953

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

GH-38936: [JS] Add bundle test for toNodeStream failures #39953

wants to merge 1 commit into from
+22 −0

Conversation

nrabinowitz
Copy link

@nrabinowitz nrabinowitz commented Feb 5, 2024 •
edited by github-actions bot
Loading

As requested here, this adds a failing test for using RecordBatchStreamWriter#toNodeStream in bundled environments. This test is not expected to run green until a fix is landed for the issue (I think #39714 is the working fix, but there was also a draft at #39472).

@nrabinowitz nrabinowitz mentioned this pull request Feb 5, 2024
Open
@domoritz
Copy link
Member

domoritz commented Feb 5, 2024

This doesn't fix #38936. I'll mark this as draft since it's not ready to be merged.

@domoritz domoritz marked this pull request as draft February 5, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz Awaiting requested review from domoritz domoritz is a code owner

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner

Assignees
No one assigned
Labels
awaiting review Awaiting review Component: JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JS] The package.json file incorrectly specifies sideEffects: false
2 participants
@nrabinowitz @domoritz