GH-39488: [Ruby] Add support for ChunkedArray in Ractor #39490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Ruby
awaiting committer review
kou
force-pushed
the
ruby-chunked-array-ractor
branch
from
ff4ed07 to
cb90353
Compare
kou
force-pushed
the
ruby-chunked-array-ractor
branch
from
cb90353 to
8d83697
Compare
|
+1 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit de3130e. There was 1 benchmark result with an error:
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
…#39490) ### Rationale for this change We can't use `@ cache ||= build_cache` idiom in Ractor because Ractor requires that shared objects are immutable. ### What changes are included in this PR? Compute caches before making ChunkedArray immutable. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#39488 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…#39490) ### Rationale for this change We can't use `@ cache ||= build_cache` idiom in Ractor because Ractor requires that shared objects are immutable. ### What changes are included in this PR? Compute caches before making ChunkedArray immutable. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#39488 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
…#39490) ### Rationale for this change We can't use `@ cache ||= build_cache` idiom in Ractor because Ractor requires that shared objects are immutable. ### What changes are included in this PR? Compute caches before making ChunkedArray immutable. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#39488 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We can't use
@cache ||= build_cacheidiom in Ractor because Ractor requires that shared objects are immutable.What changes are included in this PR?
Compute caches before making ChunkedArray immutable.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.