GH-15192: [C++] Bring back case_when tests for union types
#39308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zanmato1984
force-pushed
the
fix-15192
branch
from
30097f0 to
c27166f
Compare
|
@github-actions crossbow submit -g cpp |
github-actions
bot
added
awaiting committer review
|
Revision: c27166f Submitted crossbow builds: ursacomputing/crossbow @ actions-ede34c36c9
|
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2308cdf. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
…pache#39308) ### Rationale for this change Bring back the problematic test case of random `case_when` on union(bool, string) type. This case used to fail. However apache#36018 already addressed the issue. More information about how it used to fail, please refer to apache#15192 (comment). ### What changes are included in this PR? Bring back the test code. ### Are these changes tested? Yes, the change is the test. ### Are there any user-facing changes? No. * Closes: apache#15192 Authored-by: zanmato <zanmato1984@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#39308) ### Rationale for this change Bring back the problematic test case of random `case_when` on union(bool, string) type. This case used to fail. However apache#36018 already addressed the issue. More information about how it used to fail, please refer to apache#15192 (comment). ### What changes are included in this PR? Bring back the test code. ### Are these changes tested? Yes, the change is the test. ### Are there any user-facing changes? No. * Closes: apache#15192 Authored-by: zanmato <zanmato1984@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Bring back the problematic test case of random
case_whenon union(bool, string) type. This case used to fail. However #36018 already addressed the issue.More information about how it used to fail, please refer to #15192 (comment).
What changes are included in this PR?
Bring back the test code.
Are these changes tested?
Yes, the change is the test.
Are there any user-facing changes?
No.