GH-33953: [Java] Pass custom headers on every request

[aiguofer]

Rationale for this change

Some flight requests don't send custom headers. This PR should fix that.

What changes are included in this PR?

Ensure custom headers are sent across on every request.

Are these changes tested?

No

Are there any user-facing changes?

Custom headers should now be attached to every call.

• Closes: [Java] JDBC driver does not send custom headers on DoGet #33953
• Closes: [Java][FlightRPC] FlightCallHeaders added to FlightClient::getStream aren't attached to call #33839
• GitHub Issue: [Java] JDBC driver does not send custom headers on DoGet #33953

[github-actions]

• Closes: [Java] JDBC driver does not send custom headers on DoGet #33953

[github-actions]

⚠️ GitHub issue #33953 has been automatically assigned in GitHub to PR creator.

[aiguofer]

Unsure what that failure is... maybe the ManagedChannel shutdown is not being propagated to other channels? Or maybe it's not waiting long enough for the shutdown to complete (there's a hardcoded 5 sec wait there I believe)

[lidavidm]

It'll be a while before I can review here but that test is known to be flaky

[aiguofer]

Great, good to know! We're currently using a JDBC driver jar I built with these changes for development of our service so we're not currently blocked. Hoping these changes can make it into the next release so we can have users use a published jar once we get to beta. I really appreciate your help and time!

[lidavidm]

Can we add unit tests here?

[aiguofer]

Sure I'll take a stab at writing some unit tests. I was thinking maybe something like ConnectionTest with a middleware that checks for the specific header values.

[aiguofer]

@lidavidm Now that I'm a bit more familiar with the code base I was able to write some better unit tests. I moved the tests to flight-core, removed the use of rules, and I'm now testing each specific flight method instead of using the JDBC connection proxy.

[aiguofer]

for the future... is there some command I can run to auto-format code to checkstyle? I haven't thought about checkstyles compliance in years, this should be automated.

[lidavidm]

for the future... is there some command I can run to auto-format code to checkstyle? I haven't thought about checkstyles compliance in years, this should be automated.

Unfortunately no. I would much prefer if we could switch to a formatter like google-java-format rather than checkstyle but that would be a somewhat disruptive refactor.

That said - feel free to raise an issue and get opinions from other Java contributors.

[lidavidm]

This is great, thank you!

[lidavidm]

Actually, I filed apache/arrow-java#213 for checkstyle - feel free to chime in there

[ursabot]

Benchmark runs are scheduled for baseline = 06f28d2 and contender = 969dd29. 969dd29 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.79% ⬆️0.15%] test-mac-arm
[Finished ⬇️1.53% ⬆️2.04%] ursa-i9-9960x
[Failed ⬇️0.29% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 969dd290 ec2-t3-xlarge-us-east-2
[Failed] 969dd290 test-mac-arm
[Finished] 969dd290 ursa-i9-9960x
[Failed] 969dd290 ursa-thinkcentre-m75q
[Finished] 06f28d20 ec2-t3-xlarge-us-east-2
[Finished] 06f28d20 test-mac-arm
[Finished] 06f28d20 ursa-i9-9960x
[Finished] 06f28d20 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java