Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Benchmark] Remove Java benchmarking or pull code from arrow-java to fix failing builds #44996

Closed
assignUser opened this issue Dec 11, 2024 · 6 comments

Comments

@assignUser
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

Java benchmarks are failing because java/ was moved to arrow-java:

https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-amd64-m5-4xlarge-linux/builds/562#0193ac96-8042-4083-aeab-4d47355004b6
https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-amd64-c6a-4xlarge-linux/builds/564#0193ac96-729c-4009-a904-005b9401185a/6-13393

We should pull the code from arrow-java for now similar to #44980

Component(s)

Benchmarking

@assignUser
Copy link
Member Author

cc @raulcd @kou

@kou
Copy link
Member

kou commented Dec 11, 2024

Where are Buildkite configuration files?

@raulcd
Copy link
Member

raulcd commented Dec 11, 2024

Does someone know where is ursabot running? I struggle to understand the workflow followed to exercise the benchmarks. The following documentation doesn't give me a clear picture to be honest:
https://github.com/apache/arrow/tree/main/dev/conbench_envs

@assignUser
Copy link
Member Author

I think apache/arrow sends merge/comment events as a webhook to ursabot, not sure where it runs or which form it has (i.e. simple script or probot or something).

@assignUser
Copy link
Member Author

The buildkite config is here @kou . I will disable the java benchmarks for now, I think we can implement them in the repo and upload the results to conbench similar how we did it for go/planning to do it in arrow-go

@kou
Copy link
Member

kou commented Jan 10, 2025

Thanks! Cc: @singh1203

assignUser added a commit to voltrondata-labs/arrow-benchmarks-ci that referenced this issue Jan 10, 2025
They are failing due to the java implementation being removed from the monorepo.
See apache/arrow#44996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants