resolve comment

apache · Jan 8, 2024 · 4ab6336 · 4ab6336
1 parent bba8938
commit 4ab6336
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/cpp/src/parquet/arrow/schema_internal.cc b/cpp/src/parquet/arrow/schema_internal.cc
@@ -89,8 +89,7 @@ Result<std::shared_ptr<ArrowType>> MakeArrowTime64(const LogicalType& logical_ty
 
 Result<std::shared_ptr<ArrowType>> MakeArrowTimestamp(const LogicalType& logical_type) {
   const auto& timestamp = checked_cast<const TimestampLogicalType&>(logical_type);
-  const bool utc_normalized =
-      timestamp.is_from_converted_type() ? true : timestamp.is_adjusted_to_utc();
+  const bool utc_normalized = timestamp.is_adjusted_to_utc();
   static const char* utc_timezone = "UTC";
   switch (timestamp.time_unit()) {
     case LogicalType::TimeUnit::MILLIS:

diff --git a/cpp/src/parquet/types.cc b/cpp/src/parquet/types.cc
@@ -345,6 +345,9 @@ std::shared_ptr<const LogicalType> LogicalType::FromConvertedType(
     case ConvertedType::DATE:
       return DateLogicalType::Make();
     case ConvertedType::TIME_MILLIS:
+      // ConvertedType::TIME_{*} are deprecated in favor of LogicalType::TIME, the
+      // compatibility for ConvertedType::TIME_{*} are listed in
+      // https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#deprecated-time-convertedtype
       return TimeLogicalType::Make(/*is_adjusted_to_utc=*/true,
                                    LogicalType::TimeUnit::MILLIS);
     case ConvertedType::TIME_MICROS: