Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-5: [Docs] Add LICENSE and NOTICE files #39

Merged
merged 7 commits into from
Nov 29, 2024
Merged

GH-5: [Docs] Add LICENSE and NOTICE files #39

merged 7 commits into from
Nov 29, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Nov 26, 2024

Closes #5

@raulcd
Copy link
Member Author

raulcd commented Nov 26, 2024

I've trimmed down and removed all dependencies that seem to refer to C++ / Python / and other implementations and left the ones that are related to Java (or seem to be related to Java).

@raulcd raulcd marked this pull request as ready for review November 26, 2024 14:32
LICENSE.txt Outdated
Comment on lines 211 to 216
--------------------------------------------------------------------------------

This product includes software from Dremio, which is made available under the
Apache License 2.0.
* Copyright (C) 2017-2018 Dremio Corporation
* https://github.com/dremio/dremio-oss
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we can remove this because we removed "Copyright (C) 2017-2018 Dremio Corporation" by apache/arrow#5602 .
Anyway, I should have asked why we can remove it when I merge...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou ! I've removed it

@raulcd
Copy link
Member Author

raulcd commented Nov 28, 2024

I've rebased main but it seems pre-commit is failing there. I've opened:

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 55fced5 into apache:main Nov 29, 2024
3 of 5 checks passed
@lidavidm lidavidm added this to the 18.2.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LICENSE.txt and NOTICE
4 participants