fix(parquet/metadata): fix default unsigned int statistics #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
force-pushed
the
fix-statistics-uint16
branch
from
5f0d5e4 to
bb1ca37
Compare
lidavidm
approved these changes
Dec 9, 2024
joellubi
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
fixes #209
What changes are included in this PR?
Fixing
UpdateSpacedstatistics methods to properly check unsigned values to ensure proper handling of default min/max values.Are these changes tested?
Yes, unit test was added to confirm.
Are there any user-facing changes?
None, other than fixing the reported bug.