chore: Fix linting check

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
apache · Jan 21, 2025 · ceecbd2 · ceecbd2
1 parent 80dabba
commit ceecbd2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 21 deletions.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -18,52 +18,41 @@
 name: Benchmarks
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
     paths:
       - ".github/workflows/benchmark.yml"
   workflow_dispatch:
-
 permissions:
   contents: read
-
 jobs:
   benchmark:
     runs-on: ubuntu-latest
     container: debian:12
-
     strategy:
       matrix:
         go: ['1.22.7']
         arch: ['amd64']
-
     steps:
       - uses: actions/checkout@v4
-
       - name: Set up Python
         uses: actions/setup-python@v4
         with:
           python-version: '3.9'
-
       - name: Install dependencies
         run: |
           apt-get update
           apt-get install -y build-essential git python3-pip
-          
       - name: Install Go ${{ matrix.go }} for Benchmarks
         uses: actions/setup-go@v5
         with:
           go-version: ${{ matrix.go }}
           cache: true
           cache-dependency-path: go.sum
-
       - name: Run Benchmarks
         if: >-
-          success() &&
-          github.event_name == 'push' &&
-          github.repository == 'apache/arrow-go' &&
-          github.ref_name == 'main'
+          success() && github.event_name == 'push' && github.repository == 'apache/arrow-go' && github.ref_name == 'main'
         env:
           CONBENCH_URL: https://conbench.ursa.dev
           CONBENCH_EMAIL: ${{ secrets.CONBENCH_EMAIL }}
@@ -73,4 +62,3 @@ jobs:
         run: |
           python3 -m pip install benchadapt@git+https://github.com/conbench/conbench.git@main#subdirectory=benchadapt/python
           python3 ci/scripts/go_bench_adapt.py
-          
diff --git a/ci/scripts/bench.sh b/ci/scripts/bench.sh
@@ -26,7 +26,7 @@ set -ex
 source_dir=${1}
 
 export PARQUET_TEST_DATA=${1}/cpp/submodules/parquet-testing/data
-pushd ${source_dir}
+pushd "${source_dir}"
 
 # lots of benchmarks, they can take a while
 # the timeout is for *ALL* benchmarks together,
@@ -36,9 +36,10 @@ go test -bench=. -benchmem -timeout 40m -run=^$ ./... | tee bench_stat.dat
 popd
 
 if [[ "$2" = "-json" ]]; then
-    go install go.bobheadxi.dev/gobenchdata@latest
-    export PATH=`go env GOPATH`/bin:$PATH
-    cat ${source_dir}/bench_*.dat | gobenchdata --json bench_stats.json
-fi    
+  go install go.bobheadxi.dev/gobenchdata@latest
+  PATH=$(go env GOPATH)/bin:$PATH
+  export PATH
+  cat "${source_dir}"/bench_*.dat | gobenchdata --json bench_stats.json
+fi
 
-rm ${source_dir}/bench_*.dat
+rm "${source_dir}"/bench_*.dat