Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
- Add license header to fpunwind_arm64.s
- Add comment explaining the motivation for TestSetNoClobberFramePointer
  • Loading branch information
nsrip-dd committed Oct 25, 2024
1 parent 2c73046 commit 128b3fe
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
16 changes: 16 additions & 0 deletions arrow/internal/testing/tools/fpunwind_arm64.s
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

TEXT ·FPUnwind(SB), $0-0
MOVD R29, R19
loop:
Expand Down
3 changes: 2 additions & 1 deletion arrow/memory/memory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ func TestSetNoClobberFramePointer(t *testing.T) {
var b [8]byte
memory.Set(b[:], 0xff)
// We should be able to safely frame pointer unwind after calling this
// function
// function. The arm64 assembly implementation used to clobber the
// frame pointer. See #150
tools.FPUnwind()
}

0 comments on commit 128b3fe

Please sign in to comment.