Fix adding auth manager to fastapi state regardless of fastapi app presence #47883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esence We were accidentally only adding the auth manager to the fastapi state if the auth manager also defines a fastapi app. We shouldn't expect all auth managers to do so.
jedcunningham
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
vincbeck
approved these changes
Mar 17, 2025
|
LGTM. One note. We are not using this |
|
Yes, I agree! I tried to refactor the handful of uses but ran into some weird test mock problems so figured today I'd fix the bug and leave the cleaning for another day. |
Makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were accidentally only adding the auth manager to the fastapi state if the auth manager also defines a fastapi app. We shouldn't expect all auth managers to do so.