Implement middleware to prevent regexp parameters and payload #47543
+214
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugraoz93
force-pushed
the
feat/47364/regexp-middleware
branch
from
a155abf to
89b669d
Compare
bugraoz93
changed the title
|
CI failures seem unrelated. Rebasing |
bugraoz93
force-pushed
the
feat/47364/regexp-middleware
branch
from
89b669d to
721b9f8
Compare
|
Okay, two tests from k8s are seems related. I will check this out to be sure, but implementation should be ready for review. |
bugraoz93
force-pushed
the
feat/47364/regexp-middleware
branch
from
721b9f8 to
dcd9a9f
Compare
pierrejeambrun
force-pushed
the
feat/47364/regexp-middleware
branch
from
dcd9a9f to
b90ca77
Compare
potiuk
reviewed
Mar 16, 2025
bugraoz93
force-pushed
the
feat/47364/regexp-middleware
branch
from
b90ca77 to
527c294
Compare
bugraoz93
commented
Mar 17, 2025
…dard requests, include model validation, update test case where violate regexp and cannot pass through in connection since nothing can now have regexp like values, exclude some fields to prevent blocker for more likely include regexp like patterns such as password
bugraoz93
force-pushed
the
feat/47364/regexp-middleware
branch
from
ef44f26 to
a297425
Compare
|
I think we should enable it by default. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #47364
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.