Support dispatching and prioritizing by user scan types #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on apache/fluo#1055 I found it cumbersome to configure Fluo and Accumulo to dispatch Fluo notification scans to a dedicated executor. With these changes its much simpler to do that. Fluo can set an execution hint like `scan_type=fluo-ntfy` and Accumulo can be configured to execute the scan based on the type without changing Fluo config or source code. Before these changes, Fluo would have required either a custom dispatcher or custom Fluo config for Accumulo executors. With these changes nothing needs to be done in Fluo.
mikewalch
reviewed
Feb 20, 2019
| @@ -341,6 +341,11 @@ default void fetchColumn(CharSequence colFam, CharSequence colQual) { | |||
| * scan, only how quickly it is returned. | |||
| * | |||
| * <p> | |||
| * Using the hint {@code scan_type=<type>} and documenting all of the types for your application | |||
| * is one strategy to consider. This allows administrators to adjust executor and prioritizer | |||
| * config for your application scan types without having to change the application source code. | |||
There was a problem hiding this comment.
You should also update the website (if needed): https://accumulo.apache.org/docs/2.x/administration/scan-executors
There was a problem hiding this comment.
keith-turner
added a commit
to keith-turner/accumulo-website
that referenced
this pull request
Feb 20, 2019
mikewalch
approved these changes
Feb 21, 2019
keith-turner
added a commit
to apache/accumulo-website
that referenced
this pull request
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on apache/fluo#1055 I found it cumbersome to configure
Fluo and Accumulo to dispatch Fluo notification scans to a dedicated
executor. With these changes its much simpler to do that. Fluo can
set an execution hint like
scan_type=fluo-ntfyand Accumulo can beconfigured to execute the scan based on the type without changing Fluo
config or source code.
Before these changes, Fluo would have required either a custom
dispatcher or custom Fluo config for Accumulo executors. With these
changes nothing needs to be done in Fluo.