Update SOFAR metadata config file #1217
Conversation
| "water_depth_units": "m", | ||
| "wave_buoy_type": "directional" | ||
| }, | ||
| "SPOT-31574C": |
There was a problem hiding this comment.
you can remove the Coral Bay deployment has it is already in the config under SPOT-31886C
There was a problem hiding this comment.
I have also noticed other issue, I missed last time I reviewed the config:
1)SPOT-1476 - the spotted name is misspelled in the config, it should be "Indented Head". Also, it seems like it is not being processed
2) There is two Cape Bridgewater deployments in the config. But I think Spot-31761C is the only active. Note: If there are multiple active deployments at a single site, we should ensure they are named distinctly to differentiate between them
| "SPOT-31715C": | ||
| { | ||
| "spotter_id": "SPOT-31715C", | ||
| "site_name": "Shark Bay 02", |
There was a problem hiding this comment.
Could you remove "02" from the site name
| "latitude_nominal": -31.85125, | ||
| "longitude_nominal": 115.6464667, | ||
| "institution": "IMOS Coastal Wave Buoys", | ||
| "institution_code": "IMOS", |
There was a problem hiding this comment.
please replace this one by UWA. This is because they used a buoy of their own for an imos deployment
| "site_name": "Hillarys", | ||
| "latitude_nominal": -31.85125, | ||
| "longitude_nominal": 115.6464667, | ||
| "institution": "University of Western Australia", |
There was a problem hiding this comment.
Apologies, I should have provided a more detailed explanation of this case: In this instance, institution should be set to "IMOS Coastal Wave Buoys" and institution_code to "UWA." This is because UWA deployed a Spotter buoy from their account for an IMOS deployment (IMOS deployment have their own tokens).institution determines which token to use. It is related to the PR #1218 you merged today
There was a problem hiding this comment.
Changed institution accordingly, thanks again for reviewing those changes.
|
Great, thanks @bpasquer. I'll build those so these changes get deployed to prod this arvo. |
No description provided.