Incorrect Type Definition for TransactionJsonParsed

[mdfr11]

Overview

I found a bug in the type definition of TransactionJsonParsed. The accountKeys field is typed as a fixed-length tuple instead of an array, causing a TypeScript error when accessing or defining multiple keys.

Steps to reproduce

1. Use the following code:

import { createSolanaRpc, signature } from '@solana/web3.js';

const rpcConnection = createSolanaRpc('https://api.mainnet-beta.solana.com');

async function getTransaction() {
  const transaction = await rpcConnection
    .getTransaction(
      signature(
        'EnU3TPTWnXxmPDjE6GAq8qwc1h734jMkkHKCu72VNQgLLLVhiDsugK2Cw66h39YLxrdcFzVctL6DB962vjirMJX',
      ),
      {
        commitment: 'confirmed',
        maxSupportedTransactionVersion: 0,
        encoding: 'jsonParsed',
      },
    )
    .send();

  return transaction;
}

getTransaction().then((res) => {
  const accKey = res?.transaction.message.accountKeys[1];

  console.log(accKey);
});

2. Observe this TypeScript error:

Tuple type '[{ pubkey: Address; signer: boolean; source: string; writable: boolean; }]' of length '1' has no element at index '1'.

Description of bug

The accountKeys field is typed as:

accountKeys: [
    {
        pubkey: Address;
        signer: boolean;
        source: string;
        writable: boolean;
    },
];

This limits accountKeys to a single element and throws an error when accessing indexes beyond [0]. However, accountKeys should support multiple objects.

Suggested Fix

Change the type to:

accountKeys: Array<{
    pubkey: Address;
    signer: boolean;
    source: string;
    writable: boolean;
}>;

[steveluscher]

Nice.

@mcintyre94, want to kill this one off?

Related: source in that data structure appears to be source?: 'transaction' | 'lookup_table' rather than source: string.

https://github.com/anza-xyz/agave/blob/8889b4ac1ea39121dffcbc95421dbffae737c1fe/transaction-status-client-types/src/lib.rs#L134-L148