Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace d3-* with @antv/vendor #1894

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: replace d3-* with @antv/vendor #1894

merged 1 commit into from
Jan 23, 2025

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Jan 23, 2025

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

Walkthrough

This pull request addresses a bug fix by replacing the d3-* imports with @antv/vendor equivalents. This change aims to streamline dependencies and potentially resolve compatibility issues. The modifications are primarily in the package.json files and a specific TypeScript file related to color parsing.

Changes

Files Summary
packages/g-lite/package.json, site/package.json Updated dependencies to replace d3-* with @antv/vendor.
packages/g-lite/src/css/parser/color.ts Replaced d3-color import with @antv/vendor/d3-color.

@hustcc hustcc merged commit 2333ba3 into next Jan 23, 2025
4 checks passed
@hustcc hustcc deleted the fix-d3-esm-require-error branch January 23, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants