Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use playwright to screenshot #1603

Merged
merged 12 commits into from
Nov 30, 2023
Merged

chore: use playwright to screenshot #1603

merged 12 commits into from
Nov 30, 2023

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Nov 22, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#1183

💡 Background and solution

  • Use Playwright to screenshot for Canvas / SVG / WebGL renderer.
  • Use golden images generated under CI enviroment instead of local.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed


// use the file system to expose the port for TestEnvironments
await mkdir(TMP_DIR, { recursive: true });
await writeFile(path.join(TMP_DIR, 'PORT'), port.toString());

Check failure

Code scanning / CodeQL

Insecure temporary file

Insecure creation of file in [the os temp dir](1).
@xiaoiver xiaoiver merged commit 4bcf7fc into next Nov 30, 2023
@xiaoiver xiaoiver deleted the chore-playwright branch November 30, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant