Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the cause of failure of multiple kind job runs on same VM #6468

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Fix the cause of failure of multiple kind job runs on same VM #6468

merged 1 commit into from
Feb 21, 2025

Conversation

jainpulkit22
Copy link
Contributor

@jainpulkit22 jainpulkit22 commented Jun 20, 2024 •
edited
Loading

There were three main causes of failure:

  1. Overriding of DOCKER_IMG_VERSION in makefile.
  2. Overriding of kubeconfig because of which, when
    we ran multiple e2e tests together it used the
    same kubeconfig which was present the default
    location, so multiple jobs used the same cluster
    and failed.
  3. Cleanup of antrea images after test.

Refer #6446 for more details

@jainpulkit22 jainpulkit22 requested a review from antoninbas June 20, 2024 07:28
@jainpulkit22 jainpulkit22 force-pushed the makefile-override-fix branch from dc8098b to aea2c7d Compare June 20, 2024 07:29
@tnqn
Copy link
Member

tnqn commented Jun 20, 2024

Several tests failed due to the change

@jainpulkit22 jainpulkit22 force-pushed the makefile-override-fix branch from aea2c7d to b0371ac Compare June 20, 2024 09:18
@jainpulkit22
Copy link
Contributor Author

Several tests failed due to the change

It is working now.

antoninbas
antoninbas previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Was the original PR introducing support for custom build tags not tested? It feels like such an issue could have been caught with some basic testing.

tnqn
tnqn previously approved these changes Jun 21, 2024
View reviewed changes
@tnqn
Copy link
Member

tnqn commented Jun 21, 2024

Was the original PR introducing support for custom build tags not tested? It feels like such an issue could have been caught with some basic testing.

+1, hope this is the last amendment.

@tnqn
Copy link
Member

tnqn commented Jun 21, 2024

/test-all

@jainpulkit22
Copy link
Contributor Author

jainpulkit22 commented Jun 21, 2024 •
edited
Loading

@KMAnju-2021 can you update the respective builders & test the latest kind jobs here?

@tnqn
Copy link
Member

tnqn commented Jun 21, 2024

@KMAnju-2021 can you test the latest kind jobs here?

@jainpulkit22 can you add some description to #6010 for how to run tests using specific build tag? I wanted to try but didn't find clear docs about it.

@jainpulkit22
Copy link
Contributor Author

jainpulkit22 commented Jun 21, 2024 •
edited
Loading

@KMAnju-2021 can you test the latest kind jobs here?

@jainpulkit22 can you add some description to #6010 for how to run tests using specific build tag? I wanted to try but didn't find clear docs about it.

sure, we just need to provide --build-tag <BUILD_TAG> while invoking the ci/jenkins/test.sh script.

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-all

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-only-all

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-all

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-only-all

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-all

@jainpulkit22 jainpulkit22 dismissed stale reviews from tnqn and antoninbas via 8a79ef4 June 25, 2024 07:27
@jainpulkit22 jainpulkit22 force-pushed the makefile-override-fix branch from b0371ac to 8a79ef4 Compare June 25, 2024 07:27
@jainpulkit22 jainpulkit22 marked this pull request as draft June 25, 2024 07:27
@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-all

1 similar comment
@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-all

@KMAnju-2021
Copy link
Contributor

/test-kind-ipv6-only-all

@jainpulkit22 jainpulkit22 force-pushed the makefile-override-fix branch from 8a79ef4 to a73cc75 Compare July 12, 2024 06:27
@jainpulkit22
Copy link
Contributor Author

/test-kind-e2e

1 similar comment
@jainpulkit22
Copy link
Contributor Author

/test-kind-e2e

@rajnkamr rajnkamr added this to the Antrea v2.2 release milestone Jul 15, 2024
This was referenced Jul 24, 2024
Merged
Open
@rajnkamr rajnkamr added the area/test/infra Issues or PRs related to test infrastructure (Jenkins configuration, Ansible playbook, Kind wrappers label Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days. You can add a label "lifecycle/frozen" to skip stale checking.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2025
@luolanzone luolanzone removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2025
@rajnkamr rajnkamr mentioned this pull request Feb 14, 2025
Merged
@jainpulkit22
Copy link
Contributor Author

@antoninbas can you merge this PR?

@antoninbas
Copy link
Contributor

@antoninbas can you merge this PR?

Please check out Lan's question above

@jainpulkit22
Copy link
Contributor Author

@antoninbas @luolanzone this PR is also ready to merge.

@jainpulkit22
Copy link
Contributor Author

/test-all

@jainpulkit22
Copy link
Contributor Author

/test-all

antoninbas
antoninbas reviewed Feb 19, 2025
View reviewed changes
@jainpulkit22 jainpulkit22 force-pushed the makefile-override-fix branch 2 times, most recently from db9911c to 293e7de Compare February 20, 2025 05:40
@jainpulkit22
Copy link
Contributor Author

/test-all

@jainpulkit22
Copy link
Contributor Author

/test-all

@luolanzone
Copy link
Contributor

/test-kind-flexible-ipam-e2e

@luolanzone
Copy link
Contributor

I noticed the flexible ipam e2e test is already covered by github workflow, so please ignore the jenkins job failure

@jainpulkit22
Fix the cause of failure of multiple kind job runs
e69b02b 
on same VM.

There were three main causes of failure:
1) Overriding of DOCKER_IMG_VERSION in makefile.
2) Overriding of kubeconfig because of which, when
we ran multiple e2e tests together it used the
same kubeconfig which was present the default
location, so multiple jobs used the same cluster
and failed.
3) Cleanup of antrea images after test.

Signed-off-by: Pulkit Jain <pulkit.jain@broadcom.com>
@luolanzone
Copy link
Contributor

/skip-all

@luolanzone luolanzone merged commit 1143a88 into antrea-io:main Feb 21, 2025
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajnkamr rajnkamr rajnkamr left review comments

@luolanzone luolanzone luolanzone approved these changes

@tnqn tnqn Awaiting requested review from tnqn

@antoninbas antoninbas Awaiting requested review from antoninbas

Assignees
No one assigned
Labels
area/test/infra Issues or PRs related to test infrastructure (Jenkins configuration, Ansible playbook, Kind wrappers
Projects
None yet
Milestone
Antrea v2.3 release
Development

Successfully merging this pull request may close these issues.
6 participants
@jainpulkit22 @tnqn @KMAnju-2021 @antoninbas @luolanzone @rajnkamr