Fix empty foreach in constraints

Signed-off-by: Krzysztof Bieganski <kbieganski@antmicro.com>

Author: kbieganski

src/V3Randomize.cpp

@@ -695,11 +695,13 @@ class ConstraintExprVisitor final : public VNVisitor {
             AstNode* const cstmtp = new AstText{fl, "ret += \" \" + "};
             cstmtp->addNext(itemp);
             cstmtp->addNext(new AstText{fl, ";"});
-            AstNode* const exprsp = new AstText{fl, "([&]{ std::string ret = \"(bvand\";"};
+            AstNode* const exprsp = new AstText{fl, "([&]{ std::string ret;"};
             exprsp->addNext(new AstBegin{
                 fl, "",
                 new AstForeach{fl, nodep->arrayp()->unlinkFrBack(), new AstCStmt{fl, cstmtp}},
                 false, true});
+            exprsp->addNext(
+                new AstText{fl, "return ret.empty() ? \"#b1\" : \"(bvand \" + ret + \")\";"});
             exprsp->addNext(new AstText{fl, "return ret + \")\"; })()"});
             AstNodeExpr* const newp = new AstCExpr{fl, exprsp};
             newp->dtypeSetString();

test_regress/t/t_constraint_foreach.v

@@ -32,8 +32,13 @@ endclass
 class D;
    rand bit posit;
    rand int x;
+   int p[$];  // empty
    int q[$] = {0, 0, 0, 0, 0};
    constraint fore {
+      foreach(p[i]) x == i;
+      if (posit == 1) {
+         foreach(p[i]) p[i] > 0;
+      }
       if (posit == 1) {
          x < 7;
          foreach(q[i])