[#72063] Fail tests on exceptions and console errors

antmicro · Jan 28, 2025 · 84d8528 · 84d8528
1 parent 9e2bd7e
commit 84d8528
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 9 deletions.
diff --git a/src/extensions/syncDualPane.js b/src/extensions/syncDualPane.js
@@ -54,7 +54,7 @@ function scrollPreviewElemIntoView({ view, matchingLine, matchingElem, behavior
 
   const elemScrollOffset = cursorBlock.top + previewTopPadding;
 
-  const top = matchingRect.top + preview.scrollTop - elemScrollOffset - previewRect.top + editor.scrollTop;
+  const top = matchingRect.top + preview.scrollTop - elemScrollOffset - previewRect.top + (editor?.scrollTop ?? 0);
   preview.scrollTo({ top, behavior });
 }
 
@@ -69,7 +69,7 @@ export function handlePreviewClickToScroll(ev, lineMap, preview, editor) {
   let elem = ev.target;
   if (!id) {
     // check parents and siblings
-    while (elem.tagName !== "HTML-CHUNK") {
+    while (elem && elem.tagName !== "HTML-CHUNK") {
       const parent = elem.parentElement;
       [id, elem] = findSoruceMappedPreviousElement(elem);
       if (id) break;

diff --git a/src/hooks/useText.js b/src/hooks/useText.js
@@ -223,12 +223,12 @@ export const useText = ({ preview }) => {
     if (preview.current == null) return;
 
     const resizeObserver = new ResizeObserver(() => {
-      editorView.value.dispatch({
+      editorView.value?.dispatch?.({
         effects: markdownUpdatedStateEffect.of(null),
       });
     });
     const mutationObserver = new MutationObserver((mutationList) => {
-      editorView.value.dispatch({
+      editorView.value?.dispatch?.({
         effects: markdownUpdatedStateEffect.of(null),
       });
       for (const mutation of mutationList) {

diff --git a/src/index.html b/src/index.html
@@ -3,6 +3,7 @@
   <head>
     <title>MyST editor Demo</title>
     <link rel="stylesheet" href="./styles/MystEditor.css" />
+    <link rel="icon" href="data:," />
     <style>
       body {
         margin: 0;
@@ -265,10 +266,7 @@
               action: () => alert("Custom button action"),
             },
           ]),
-          spellcheckOpts: {
-            dict: "en_US",
-            dictionaryPath: "/myst-editor/dictionaries",
-          },
+          spellcheckOpts: { dict: "en_US", dictionaryPath: `${window.location.pathname}dictionaries` },
           syncScroll: true,
         },
         document.getElementById("myst"),

diff --git a/src/mystState.js b/src/mystState.js
@@ -97,7 +97,7 @@ const defaults = {
     color: "#ff0000",
     mode: "websocket",
   },
-  spellcheckOpts: { dict: "en_US", dictionaryPath: "/dictionaries" },
+  spellcheckOpts: null,
   customRoles: [],
   transforms: [],
   customDirectives: [],

diff --git a/tests/myst-editor.spec.ts b/tests/myst-editor.spec.ts
@@ -592,6 +592,17 @@ const insertChangesAndCheckOutput = async (page: Page, changes: ChangeSpec | nul
 const applyPageOpts = async (page: Page, opts: object) => {
   let query = new URLSearchParams();
   Object.entries(opts).forEach(([k, v]) => query.set(k, v));
+
+  // Fail on errors
+  page.on("pageerror", (err) => {
+    throw new Error(`Unhandled page exception: ${err.stack || err}`);
+  });
+  page.on("console", (msg) => {
+    if (msg.type() === "error") {
+      throw new Error(`Console error: ${msg.text()} ${JSON.stringify(msg.location())}`);
+    }
+  });
+
   await page.goto("/?" + query.toString());
   await page.waitForSelector(".cm-content");
   return page;