Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour with NR.OBSERVE in multi #8

Open
stockholmux opened this issue Nov 22, 2016 · 3 comments
Open

Unexpected behaviour with NR.OBSERVE in multi #8

stockholmux opened this issue Nov 22, 2016 · 3 comments

Comments

@stockholmux
Copy link

NR.OBSERVE doesn't reject the wrong number of arguments when in a MULTI. Here I'm running NR.OBSERVE with no arguments.

> MULTI
OK
> NR.OBSERVE
QUEUED
> NR.OBSERVE
QUEUED
> EXEC
1) (error) ERR wrong number of arguments for 'nr.observe' command
2) (error) ERR wrong number of arguments for 'nr.observe' command

I would expect that if you run NR.OBSERVE you would receive an immediate error and/or trigger an EXECABORT when running the EXEC command.

@itamarhaber
Copy link
Contributor

This is actually an issue of modules API itself because this is the behavior of any module command. There's also a difference in how COMMAND GETKEYS responds for core and module commands if passed w/ incorrect arguments.

@stockholmux
Copy link
Author

@itamarhaber So, am I reading that this is the expected behaviour? Or will a fix to the modules API make module commands behave the same way as the in-built commands?

@itamarhaber
Copy link
Contributor

The latter, but there isn't a relevant open issue - perhaps you should migrate this issue to the Redis repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants