Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RevMiddleware: Clone + PubSubClient #743

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

Autoparallel
Copy link
Collaborator

@Alexangelj is this what you want to try working with?

@0xJepsen 0xJepsen marked this pull request as ready for review December 13, 2023 23:03
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (6015ac2) 52.63% compared to head (c851c5e) 52.51%.
Report is 1 commits behind head on main.

Files Patch % Lines
arbiter-core/src/middleware/mod.rs 0.00% 18 Missing ⚠️
arbiter-core/src/middleware/connection.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   52.63%   52.51%   -0.12%     
==========================================
  Files          36       36              
  Lines        7277     7293      +16     
==========================================
  Hits         3830     3830              
- Misses       3447     3463      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xJepsen 0xJepsen added this pull request to the merge queue Dec 14, 2023
@0xJepsen 0xJepsen removed this pull request from the merge queue due to a manual request Dec 14, 2023
@0xJepsen 0xJepsen merged commit e9183c7 into main Dec 14, 2023
11 checks passed
@0xJepsen 0xJepsen deleted the feat/impl-traits-for-revmmiddleware branch December 14, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants