fix: sort by alias name (#159)

antfu-collective · Feb 4, 2025 · 645e312 · 645e312
1 parent dcbd53a
commit 645e312
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/io/dependencies.ts b/src/io/dependencies.ts
@@ -46,7 +46,7 @@ export function dumpDependencies(deps: ResolvedDepChange[], type: DepType) {
   const data: Record<string, any> = {}
   deps
     .filter(i => i.source === type)
-    .sort((a, b) => a.name.localeCompare(b.name))
+    .sort((a, b) => (a.aliasName || a.name).localeCompare(b.aliasName || b.name))
     .forEach((i) => {
       const version = i.update ? i.targetVersion : i.currentVersion
       let targetLeaf = data

diff --git a/test/dumpDependencies.test.ts b/test/dumpDependencies.test.ts
@@ -1,9 +1,9 @@
-import type { ResolvedDepChange } from '../src/types'
+import type { DepType, ResolvedDepChange } from '../src/types'
 import { describe, expect, it } from 'vitest'
 import { dumpDependencies } from '../src/io/dependencies'
 
 describe('dumpDependencies', () => {
-  function makeDepChange(source: string, override: Partial<ResolvedDepChange> = {}) {
+  function makeDepChange(source: DepType, override: Partial<ResolvedDepChange> = {}) {
     return {
       name: '@types/semver',
       currentVersion: '^7.3.10',
@@ -89,4 +89,14 @@ describe('dumpDependencies', () => {
       }
     `)
   })
+
+  it('dump sorted by key', () => {
+    const dump = dumpDependencies([
+      makeDepChange('dependencies', { name: 'd', aliasName: 'a' }),
+      makeDepChange('dependencies', { name: 'c' }),
+      makeDepChange('dependencies', { name: 'b' }),
+    ], 'dependencies')
+    expect(Object.keys(dump)).toEqual(['a', 'b', 'c'],
+    )
+  })
 })