Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/simplify interface #49

Merged
merged 13 commits into from
Dec 14, 2023

merge master

bf88e41
Select commit
Loading
Failed to load commit list.
Merged

Refactor/simplify interface #49

merge master
bf88e41
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Dec 14, 2023 in 1s

14.12% (+1.61%) compared to 587d3db

View this Pull Request on Codecov

14.12% (+1.61%) compared to 587d3db

Details

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (587d3db) 12.50% compared to head (bf88e41) 14.12%.

Files Patch % Lines
...ebrtcandroidframework/core/PermissionsHandler.java 37.50% 17 Missing and 3 partials ⚠️
...framework/api/DefaultConferenceWebRTCListener.java 64.15% 11 Missing and 8 partials ⚠️
...a/webrtcandroidframework/core/MediaFileReader.java 86.25% 11 Missing and 7 partials ⚠️
...rtcandroidframework/api/DefaultWebRTCListener.java 92.30% 3 Missing and 4 partials ⚠️
...ebrtcandroidframework/api/WebRTCClientBuilder.java 96.22% 2 Missing ⚠️
...tcandroidframework/websocket/WebSocketHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
+ Coverage     12.50%   14.12%   +1.61%     
- Complexity      289      332      +43     
============================================
  Files           152      155       +3     
  Lines         10912    10332     -580     
  Branches       1240     1138     -102     
============================================
+ Hits           1365     1459      +94     
+ Misses         9354     8707     -647     
+ Partials        193      166      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov