-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to ansys tools and decouple requirements #532
Conversation
for more information, see https://pre-commit.ci
…s into tests/show-methods
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
# Conflicts: # src/ansys/speos/core/lxp.py # src/ansys/speos/core/project.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
==========================================
+ Coverage 86.71% 86.81% +0.10%
==========================================
Files 35 35
Lines 3817 3846 +29
==========================================
+ Hits 3310 3339 +29
Misses 507 507 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
warning when importing module error when executing function
… feat/switch_to_ansys_tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can we get a new release with these changes? |
Description
Comply with #901
Switch from native pyvista to ansys-tools-vizualization-interface
only basic implementation done additional steps will be coming
Issue linked
#531
Checklist
feat: add optical property
)