Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to ansys tools and decouple requirements #532

Merged
merged 37 commits into from
Apr 1, 2025

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented Apr 1, 2025

Description

Comply with #901
Switch from native pyvista to ansys-tools-vizualization-interface

only basic implementation done additional steps will be coming

Issue linked

#531

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

SMoraisAnsys and others added 25 commits March 27, 2025 09:44
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
# Conflicts:
#	src/ansys/speos/core/lxp.py
#	src/ansys/speos/core/project.py
@StefanThoene StefanThoene self-assigned this Apr 1, 2025
@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (99bb942) to head (11d42b6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
+ Coverage   86.71%   86.81%   +0.10%     
==========================================
  Files          35       35              
  Lines        3817     3846      +29     
==========================================
+ Hits         3310     3339      +29     
  Misses        507      507              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

warning when importing module
error when executing function
@StefanThoene StefanThoene changed the title feat: switch to ansys tools feat: switch to ansys tools and decouple requirements Apr 1, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StefanThoene StefanThoene marked this pull request as ready for review April 1, 2025 13:45
@StefanThoene StefanThoene merged commit cc9ab8e into main Apr 1, 2025
28 checks passed
@StefanThoene StefanThoene deleted the feat/switch_to_ansys_tools branch April 1, 2025 14:16
@RobPasMue
Copy link
Member

Can we get a new release with these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants