-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Add a Message Manager for App #1068
Conversation
… into fix/add_message
This comment was marked as resolved.
This comment was marked as resolved.
An on/off for complete_info seems inflexible. How about this:
|
Added this feature and updated the PR descriptions as well |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
+ Coverage 81.37% 81.58% +0.20%
==========================================
Files 40 41 +1
Lines 2755 2813 +58
==========================================
+ Hits 2242 2295 +53
- Misses 513 518 +5 |
@koubaa When app starts there is already a warning message saying license checkout is delayed. This was causing all the tests to fail because how test is written assuming zero message at the beginning. |
Fixes #440