add module to manage Kea DHCP subnets #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, it was not possible to manage the subnets in the Kea DHCP service. I.e. it was not possible to add/remove subnets. This change adds a new module that allows to manage subnets. The code is split in two python files. 'plugins/modules/dhcp_subnet.py' and 'plugins/module_utils/main/dhcp_subnet_v4.py'
woelfle
force-pushed
the
manage-dhcp-subnets
branch
from
74e42f0 to
8e2d72c
Compare
|
Thank you - will take a look later that week 👍🏼 |
|
Yeah - a lot of the API functionality was still missing in the draft. Would you mind adding the documentation? At: https://github.com/ansibleguy/collection_opnsense/blob/latest/docs/source/modules/dhcp.rst |
Sure. Try to get this done this weekend. Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, it was not possible to manage the subnets in the Kea DHCP service. I.e. it was not possible to add/remove subnets.
This change adds a new module that allows to manage subnets. The code is split in two python files. 'plugins/modules/dhcp_subnet.py' and 'plugins/module_utils/main/dhcp_subnet_v4.py'
@ansibleguy I'd consider this PullRequest a draft only. I am not that much familiar with the codebase. Can you please do a review and give me feedback on what is missing from your point of view?