Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change implementation of "delay" to a single asyncio task #57

Open
AlanCoding opened this issue Feb 10, 2025 · 0 comments
Open

Change implementation of "delay" to a single asyncio task #57

AlanCoding opened this issue Feb 10, 2025 · 0 comments
Labels
refactoring code build-out and clean-up

Comments

@AlanCoding
Copy link
Member

As I started on an implementation of a "timeout" feature in #52, this was put in a single asyncio task. This is probably slightly better than creating a new task for each individual thing that needs a timeout. However, the "delay" feature, implemented in the main.py module right now creates a new task for every delayed task. This somewhat complicates error handling, and you have to cancel an arbitrary list of tasks when shutting down. It would also be better to have a constant number of asyncio tasks globally, so that they would be countable generally.

So this issue asks for a change in the implementation that the main logic puts delayed tasks in a single task. Purely refactoring.

@AlanCoding AlanCoding added the refactoring code build-out and clean-up label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring code build-out and clean-up
Projects
None yet
Development

No branches or pull requests

1 participant