More PyGithub dep and license housekeeping

[AlanCoding]

SUMMARY

Yesterday, in some panicked fixing, I added a duplicated license after @arrestle added the same PyNaCl, because I used capitals and she used lowercase. So this removes one of them. I favor the capitalization, and tests allow it... but the source check doesn't allow capitals.

Additionally:

This implements the comment from @webknjaz

https://github.com/ansible/awx/pull/15850/files/5d167b60d83b73ebfdd31a243f0d9a7bf1a478eb#diff-2d88edd924033b49783dcb4f93a0ed0ec8aae0b6aac3bad984a2c1d323b93c37

The correct thing to do would be to depend on awx-plugins-core [credentials-github-app] that declares the dependency.

This PR does that.

Ran ./updater.sh run, which proved the theory to be correct.

ISSUE TYPE

• Bug, Docs Fix or other nominal change

COMPONENT NAME

• API

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.29%. Comparing base (fa099fe) to head (da1703b).

✅ All tests successful. No failed tests found.

[webknjaz]

Honestly, I'm surprised that all the other extras that awx-plugins declares aren't depended on.. They definitely should be. I assume awx works because it happens to depend on the same things but I'll break if it stops.

[webknjaz]

This is a bit of a Frankenstein syntax. It's better to use the normal dep+extras spec. The #egg bit is a part of older syntax that existed pre pkg @ url, almost as a hack. The ecosystem doesn't even use the concept of eggs anymore except for when the legacy abstractions leak into the UI...

Here you go:

Suggested change

	awx-plugins-core @ git+https://github.com/ansible/awx-plugins.git@devel#egg=awx-plugins-core[credentials-github-app]
	awx-plugins-core [credentials-github-app] @ git+https://github.com/ansible/awx-plugins.git

[AlanCoding]

That argument would seem to apply equally to django-ansible-base specification on the line before. Do you agree?

[webknjaz]

Absolutely! I just didn't want to enlarge the PR scope.

[webknjaz]

I think that having awx-plugins-core [credentials-github-app] here too should work. It should have the abstract spec that would be augmented with git additionally in some envs.