Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pbr dependency #15806

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Remove pbr dependency #15806

wants to merge 2 commits into from

Conversation

AlanCoding
Copy link
Member

SUMMARY

ansible/ansible-runner#1234

This went out in version 2.4.0

This should only be relevant to the control plane, so as long as our current version of runner is high enough we should be okay to make this change.

Ran the ./updater.sh run script, explaining some of the diff here.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 3, 2025
@AlanCoding AlanCoding requested a review from simaishi February 3, 2025 16:36
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.29%. Comparing base (a74e730) to head (432e4cb).
Report is 3 commits behind head on devel.

✅ All tests successful. No failed tests found.

@AlanCoding AlanCoding marked this pull request as ready for review February 3, 2025 18:32
@simaishi
Copy link
Contributor

simaishi commented Feb 4, 2025

# Remove pbr from requirements.in when moving ansible-runner to requirements.in can be removed as well. (https://github.com/ansible/awx/blob/devel/requirements/requirements_git.txt#L2)

Copy link

sonarqubecloud bot commented Feb 5, 2025

# via -r /awx_devel/requirements/requirements.in
# via
# -r /awx_devel/requirements/requirements.in
# django-ansible-base
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is picking up upstream changes in DAB that happened independently. @zkayyali812 ansible/django-ansible-base#685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants