Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default, do not count indirect hosts #15801

Merged

Conversation

AlanCoding
Copy link
Member

@AlanCoding AlanCoding commented Jan 31, 2025

SUMMARY

This gives me a satisfying conclusion to the dance between the control process and the event processing for indirect host processing.

I'm changing the default of our mark to process these, event_queries_processed to False, meaning that the default behavior is that it won't do anything.

Then, if the control process (via the artifacts handler) finds the even_query file (in any form), it uses this field to make a note to process the data for that job.

This perhaps handles the issue better than the feature flag itself, because on a job-by-job basis, we control the task noise in the dispatcher. The big concern I had was the polling loop that was in there, because sleeping tasks can be risky in the wild, occupying workers and leading to saturation and cluster death.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@AlanCoding
Copy link
Member Author

This lint failure looks like it's not running against the right files???

linters: commands[1]> flake8 awx awxkit awx_collection
awx/main/tests/functional/tasks/test_host_indirect.py:16:1: F401 'awx.main.tests.functional.conftest.organization' imported but unused
awx/main/tests/functional/tasks/test_host_indirect.py:48:36: F811 redefinition of unused 'organization' from line 16
awx/main/tests/functional/tasks/test_host_indirect.py:62:32: F811 redefinition of unused 'organization' from line 16
awx/main/tests/functional/tasks/test_host_indirect.py:68:32: F811 redefinition of unused 'organization' from line 16
linters: exit 1 (7.48 seconds) /awx_devel> flake8 awx awxkit awx_collection pid=277

@AlanCoding
Copy link
Member Author

Now it's making sense, it seems that it rebased against the base branch which introduced this unused fixture. So I rebased to take care of that. Going to see about merging now, since the live tests passed.

@AlanCoding AlanCoding merged commit 73ce83d into ansible:feature_indirect-host-counting Jan 31, 2025
19 checks passed
pb82 pushed a commit that referenced this pull request Feb 14, 2025
* By default, do not count indirect hosts

* Fix copy paste goof

* Fix linter issue from base branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants