By default, do not count indirect hosts #15801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This gives me a satisfying conclusion to the dance between the control process and the event processing for indirect host processing.
I'm changing the default of our mark to process these,
event_queries_processed
toFalse
, meaning that the default behavior is that it won't do anything.Then, if the control process (via the artifacts handler) finds the even_query file (in any form), it uses this field to make a note to process the data for that job.
This perhaps handles the issue better than the feature flag itself, because on a job-by-job basis, we control the task noise in the dispatcher. The big concern I had was the polling loop that was in there, because sleeping tasks can be risky in the wild, occupying workers and leading to saturation and cluster death.
ISSUE TYPE
COMPONENT NAME