Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When job is running, selected EE is not visible in the UI, it appears only after it finishes #14931

Open
4 of 9 tasks
benapetr opened this issue Feb 27, 2024 · 8 comments
Open
4 of 9 tasks

Comments

@benapetr
Copy link

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I might not receive a timely response.

Feature type

New Feature

Feature Summary

Right now EE that was selected is invisible to user, see here

image

A specific version of EE was used for this template, but it's not visible anywhere in the job history (it was changed between runs) and therefore we can't verify if that specific version was really used or not and which version of EE the job was started with

Select the relevant components

  • UI
  • API
  • Docs
  • Collection
  • CLI
  • Other

Steps to reproduce

Create a template, pick a custom EE, start a job, then edit template, pick another EE, start a new job. You won't be able to tell which job was started with which EE.

Current results

See above

Sugested feature result

Make it so that chosen EE version is visible just like other fields, job template, project etc.

Additional information

No response

@benapetr
Copy link
Author

EE can be chosen here

image

But it's not possible to see which one was chosen for a job that is running (I just noticed this information appears later when job already finishes, but it should probably be visible even when it's running)

@kurokobo
Copy link
Contributor

@benapetr
Hi, indeed EE is not shown during the job run, but once the job is completed, the Details is updated to include used EE.

image

Does this not satisfy your requirement?

@kurokobo
Copy link
Contributor

Ah, I missed your second post. You already knew that. My apologies 😞

@thedoubl3j
Copy link
Member

hey @benapetr can you look at the API endpoints for these jobs and see if it shows up there? like kick off a job and go to the job endpoint and see if it shows up before the job ends.

@marek1712
Copy link

@thedoubl3j it's shown for both Running and Completed jobs:
image
I guess that's matter of some condition when Details page is generated. This?

{job.type !== 'workflow_job' && !isJobRunning(job.status) && (
<ExecutionEnvironmentDetail
dataCy="job-execution-environment"
executionEnvironment={executionEnvironment}
helpText={jobHelpText.executionEnvironment}
verifyMissingVirtualEnv={false}

@thedoubl3j
Copy link
Member

ok, good. not the best but the api is showing @benapetr thanks for reporting. @jbradberry if I recall you had a follow up for this or something?

@benapetr benapetr changed the title Show EE that was used for a job When job is running, selected EE is not visible in the UI, it appears only after it finishes Mar 3, 2024
@kurokobo
Copy link
Contributor

kurokobo commented Mar 6, 2024

I know nothing about background but according to the commit message (2c5bcf2), EE is hidden by design until job completes.

If we know if the concerns we had then still apply to the current implementation, we can determine if we can change the conditions under when EEs are displayed.

Update UI to reflect new API EE changes

  • Show resolved EE for job template details.
  • Do not show EE if a certain job status still running, since EE on the API is not set yet. It was causing the bug to temporarily how missing resource.
  • Fix discrepancy about job types for list and details.

See: #10327
Also: #10399

@jbradberry
Copy link
Contributor

jbradberry commented Mar 6, 2024

I know nothing about background but according to the commit message (2c5bcf2), EE is hidden by design until job completes.

That, unfortunately, was a misunderstanding. The EE should be known when the job first starts running. It shouldn't need to wait until the job is complete.

Though there was also some question about what to do about Workflows, since what matters is the EE chosen on each node's job and the EE field on the workflow itself is (mostly?) irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants