Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WARN on empty/template meta/main.yaml #4379

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

GElkayam
Copy link
Contributor

WARNING Ignored exception from RoleNames.matchyaml while processing roles/xxx/meta/main.yaml (meta): 'NoneType' object has no attribute 'get'

@GElkayam
Copy link
Contributor Author

Related to #3991

@GElkayam GElkayam marked this pull request as ready for review November 7, 2024 11:15
@GElkayam GElkayam requested a review from a team as a code owner November 7, 2024 11:15
Copy link
Contributor

@audgirka audgirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GElkayam Thanks for the PR but it needs a test

WARNING  Ignored exception from RoleNames.matchyaml while processing roles/xxx/meta/main.yaml (meta): 'NoneType' object has no attribute 'get'
@ssbarnea ssbarnea force-pushed the fix/empty/template_meta/main.yaml branch from 43c19f3 to f974604 Compare January 20, 2025 10:44
@ssbarnea ssbarnea marked this pull request as ready for review January 20, 2025 10:51
@ssbarnea ssbarnea dismissed audgirka’s stale review January 20, 2025 10:51

tested manually

@ssbarnea ssbarnea merged commit 971d330 into ansible:main Jan 20, 2025
26 checks passed
@GElkayam
Copy link
Contributor Author

Thanks @ssbarnea , I was struggling with getting tests to work to add them, although it is a straight forward fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants