Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload generated RST files after docs-build #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Apr 26, 2022

Because the RST files are regenerated from modules the line numbers can be misleading. Upload a separate artefact bundle with the generated RST files.

Copy link
Collaborator

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, thanks! I would like to do some tests. Right now we don't have tests for the shared workflows (#29) so they need to be tested in another repo, by referencing the PR branch version instead of the repo main version.

I will try to do that as soon as I can. Alternatively, you can change your collections' to point at your version, that would be helpful, and let you use your changes right away (can change back once merged).

What do you think about adding the same options to the push workflow too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants