Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs_facts: set parameter "type" as a list #9697

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Feb 8, 2025

Plus minor readability improvements

SUMMARY

Fixes #5909

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zfs_facts

Plus minor readability improvements
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Feb 8, 2025
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch labels Feb 8, 2025
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite this being a bugfix I'd not backport it to stable-9 since it can also be seen as a new feature (since it never did what it claimed to do anyway).

plugins/modules/zfs_facts.py Outdated Show resolved Hide resolved
@felixfontein felixfontein removed the backport-9 Automatically create a backport for the stable-9 branch label Feb 8, 2025
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit 165106d into ansible-collections:main Feb 10, 2025
138 checks passed
Copy link

patchback bot commented Feb 10, 2025

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/165106d2bda7560927499004323400a2d25a4c23/pr-9697

Backported as #9716

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Feb 10, 2025
patchback bot pushed a commit that referenced this pull request Feb 10, 2025
* zfs_facts: set parameter "type" as a list

Plus minor readability improvements

* add changelog frag

* Update plugins/modules/zfs_facts.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 165106d)
@felixfontein
Copy link
Collaborator

@russoz thanks!

felixfontein pushed a commit that referenced this pull request Feb 10, 2025
…e" as a list (#9716)

zfs_facts: set parameter "type" as a list (#9697)

* zfs_facts: set parameter "type" as a list

Plus minor readability improvements

* add changelog frag

* Update plugins/modules/zfs_facts.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 165106d)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the 5909-zfs-facts-type branch February 11, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-10 Automatically create a backport for the stable-10 branch bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
3 participants