Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ng lint and re-enable linting in the script #3461

Closed
wants to merge 1 commit into from

Conversation

robertIsaac
Copy link
Contributor

Checklist

  • Issue number for this PR: NA
  • Docs included?: no
  • Test units included?: no
  • In a clean directory, yarn install, yarn test run successfully? NA

Description

for some reason in 582c028 the some of the eslint packages were removed and in 4f7932c the linting were disabled in github workflow
this PR revert these changes
also fixes the files that were failing

@jamesdaniels jamesdaniels deleted the branch angular:v17 December 7, 2023 03:18
@robertIsaac
Copy link
Contributor Author

Hi @jamesdaniels
Why did you close this PR?

@jamesdaniels
Copy link
Member

Sorry should have left a comment, lint has been reenabled. It was disabled since I was developing against v17 canaries before @angular-eslint had their own

@jamesdaniels
Copy link
Member

v17 branch has been merged and 17.0.0 final cut

@robertIsaac
Copy link
Contributor Author

Sorry should have left a comment, lint has been reenabled. It was disabled since I was developing against v17 canaries before @angular-eslint had their own

Thanks for explaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants