feat: Add Optional ID for AMP Packet #813
Open
+204
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
crnbarr93
reviewed
Feb 17, 2025
crnbarr93
reviewed
Feb 17, 2025
crnbarr93
reviewed
Feb 17, 2025
crnbarr93
reviewed
Feb 19, 2025
| current_index: u32, | ||
| ) -> Result<String, ContractError> { | ||
| // Split the ID into chain_id and index parts at first occurrence of '.' | ||
| let (chain_id, index_str) = id |
There was a problem hiding this comment.
This should probably have 3 elements, chain.block.index as I think the transaction index is per block?
crnbarr93
reviewed
Feb 22, 2025
| @@ -304,6 +304,7 @@ pub struct AMPPkt { | |||
| /// Any messages associated with the packet | |||
| pub messages: Vec<AMPMsg>, | |||
| pub ctx: AMPCtx, | |||
| pub id: Option<String>, | |||
There was a problem hiding this comment.
We shouldn't need this anymore, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: ANDCI-74
Implementation
When the kernel receives an AMPPkt, it checks if an ID exists, if not, it generates one. If it already exists then it leaves it as is (should also validate the ID which is a WIP).
The ID is generated by hashing the string of the appended block, origin, and nonce. Then prepending the hash string with the chain id.
Unsure about the nonce generation, after that's finalized it will be easier to create the validation function for the AMPPkt ID.
Testing
None yet.
Version Changes
kernel:1.2.1-b.3->1.2.1-b.4std:1.5.1-b.6->1.5.1-b.7Checklist