Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media3-ui-compose integration #199

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

media3-ui-compose integration #199

wants to merge 3 commits into from
+258 −183

Conversation

chikoski
Copy link
Contributor

This PR replaces the AndroidView composable in the player screen with PlayerSurface from media3-ui-compose library.

In addition to that, this PR updates the dependencies.

JolandaVerhoef
JolandaVerhoef approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@JolandaVerhoef JolandaVerhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, LGTM otherwise. Do look into PresentationState and how it's used in the demo, it might be a nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JolandaVerhoef JolandaVerhoef JolandaVerhoef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chikoski @JolandaVerhoef