Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of spacers in LazyLists and LazyGrids #156

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

chikoski
Copy link
Contributor

This pull request will remove the Spacers in the LazyLists and LazyGrids to set margins between the lists / grids and other components by specifying the contentPadding parameter to the scrollable containers.

This PR also updates the dependencies.

@chikoski chikoski requested a review from mlykotom March 22, 2024 07:04
Copy link
Contributor

@mlykotom mlykotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions for newer stable versions, otherwise LGTM!

coil-compose = "2.5.0"
compose-bom = "2023.10.01"
compose-bom = "2024.02.02"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
compose-bom = "2024.02.02"
compose-bom = "2024.03.00"

Comment on lines +3 to +4
android-gradle-plugin = "8.2.2"
android-test-plugin = "8.2.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
android-gradle-plugin = "8.2.2"
android-test-plugin = "8.2.2"
android-gradle-plugin = "8.3.1"
android-test-plugin = "8.3.1"

hilt-navigation-compose = "1.1.0"
hilt-android = "2.48.1"
hilt-navigation-compose = "1.2.0"
hilt-android = "2.49"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hilt-android = "2.49"
hilt-android = "2.51"

@chikoski
Copy link
Contributor Author

Thanks for quick response!

Updated the version catalog with the suggested ones.

@chikoski chikoski merged commit 2b4fc33 into android:main Mar 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants