Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed references in Typography sample. #198

Closed
wants to merge 4 commits into from

Conversation

jwill
Copy link
Contributor

@jwill jwill commented Jan 31, 2024

body1/body2/h4 don't exist in M3 Typography. The options are {display|headline|title|body|label}{Small|Medium|Large}. Changed snippet to reflect M3.

body1/body2/h4 don't exist in M3 Typography. The options are {display|headline|title|body|label}{Small|Medium|Large}.
@arriolac
Copy link
Contributor

arriolac commented Jan 31, 2024

Hey @jwill, can you update your branch with the latest on main from origin? I added commit fdc1b8e which I think should fixed the failed workflow (context: https://github.com/android/snippets/actions/runs/7720213626/job/21083922073?pr=198).

Edit: I created PR #1 on your branch to update your branch with main.

@arriolac
Copy link
Contributor

arriolac commented Feb 1, 2024

Looks like git-auto-commit-action@v4 in the GH build.yml workflow is failing due to the PR coming from a fork. We should probably only apply this for PRs from a branch in this repo.

@arriolac
Copy link
Contributor

arriolac commented Feb 8, 2024

Closed by #207. Thanks @jwill for fixing!

@arriolac arriolac closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants