-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NAT64 prefix sizes other than /96 (RFC6052) #6
base: main
Are you sure you want to change the base?
Add support for NAT64 prefix sizes other than /96 (RFC6052) #6
Conversation
3a1548f
to
e2d6aae
Compare
fe11a8b
to
50bec7c
Compare
53a7c0f
to
5362596
Compare
You probably wanted to rebase instead :) |
dfd3aa1
to
2b71280
Compare
Yeah, I did. Stupid git. Fixed. |
2b71280
to
ead05d1
Compare
Validate some more stuff, add useful return code.
88632b2
to
284e496
Compare
Okay, I think this PR should now be somewhat ready for review as well if you want to take a look. Once my other PR (#8) is merged I'm going to add a test or two for this PR as well (so the other PR should probably be reviewed and merged first), I don't want to do that now so I don't get merge conflicts again that I need to fix. |
Thanks! I saw you added a test based on Python — since the main implementation of Meson is written in Python (and I want to add Meson build files), yeah, maybe it’s reasonable after all to require Python for tests. Then we probably don’t need to try and find dig, netcat, telnet and other networking tools 🙂 |
The python test was in the other PR (netlink), but yeah, that's what I thought. Python is not that uncommon, and I don't think writing a netlink test in Bash or plain SH is going to be easy. |
This PR fixes a couple small bugs I've noticed:
192.168.0.0/255.255.0.0
can now also just be entered as192.168.0.0/16
.nat64_suffix
, if needed. If not set, these bits are set to 0.Right now I haven't yet been able to fully test this, so I'm making it a draft PR in case you already want to look at the code. I'm going to try to do a bunch of testing in the next couple days to make sure that's all working as intended.